Closed rohitrajmishra closed 1 month ago
We tried to investigate a bit, It seems below is suspected code in repo,
Code in this file mentions magenta80
and 80
shade for other colors for white/g10
theme, which is different from documentation which mentions magenta70
or 70
shade for such color tokens.
Yes, I am seeing the same thing. I've found this PR https://github.com/carbon-design-system/carbon/pull/10287 where we updated the dark theme tag tokens to the 70 scale but not the light theme ones. I'm trying to figure out if we've since decided to update the light values as well and which assets have the bug.
Update: The code is wrong, the token $tag-color-magenta
(used for the text) in the light theme tags should be using the 70 scale. I see this in design specs as far back as v10. Update needed across tag suite color. Design kit and website do not need edits
tag token | White theme | Gray 10 | Gray 90 | Gray 100 |
---|---|---|---|---|
$tag-color-magenta |
Magenta ~80~ 70 | Magenta ~80~ 70 | Magenta 20 | Magenta 20 |
Package
@carbon/themes
Browser
No response
Package version
v11.39.0
React version
v16.14.0
Description
As per color guide/documentation
https://carbondesignsystem.com/elements/color/tokens/#tag
the color for token
$tag-color-magenta
we expect colormagenta70 -- #9f1853
,But in practice the resulting color is
magenta80 -- #740937
.Similar is the case with other tag colors also. E.g.
This results in darker shade of colors applied to app then design intended.
Reproduction/example
https://stackblitz.com/edit/github-sxced5-yboywq?file=src%2Fmain.jsx
Steps to reproduce
magenta80
with what is mentioned inwhite/g10
theme(magenta70
) https://carbondesignsystem.com/elements/color/tokens/#tagSuggested Severity
None
Application/PAL
No response
Code of Conduct