carbon-design-system / carbon

A design system built by IBM
https://www.carbondesignsystem.com
Apache License 2.0
7.88k stars 1.82k forks source link

[Feature Request]: Add batch actions bar below the Data table tool bar #17844

Open pilarfernandezz opened 1 month ago

pilarfernandezz commented 1 month ago

The problem

In the current DataTables, when selecting rows and generating the Batch Actions blue bar is rendered on top of the Action toolbar. With that, the user can't do actions like update a search query.

Without the Batch Actions bar (search bar and actions button shown): Image

With the Batch Actions bar (search bar and actions button are hidden): Image

The solution

Have a new prop that allows the Batch Actions bar to be displayed bellow the Actions Toolbar.

Example: Image

Examples

No response

Application/PAL

Carbon for IBM Products

Business priority

Medium Priority = upcoming release but is not pressing

Available extra resources

No response

Code of Conduct

github-actions[bot] commented 1 month ago

Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team.

If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request you or other volunteers from the community to work on this issue.

tay1orjones commented 1 month ago

@pilarfernandezz Hey thanks for opening this and putting up a PR so quickly! I spoke with @laurenmrice about this just now. We've heard this problem before and agree it feels like a valid ask. It's a big change though that will require a bit more work both in the existing PR and afterwards.

  1. A finalized design spec from @carbon-design-system/design
    • Should this be an option (as you have it in the PR now)
    • Or do we want this to fully replace the current interaction that exists?
    • What could/should the keyboard interaction path be?
  2. Update the PR to match design spec
    • This may include reevaluating the prop approach to something else
  3. Ensure the PR covers all the bases
    • Documentation
    • AVT
    • VRT
    • Backwards compatibility (or a feature flag if it's not backwards compatible)
  4. Mirror this update over into @carbon/web-components
  5. Update carbon-website documentation
  6. Update the figma design kit

For now I'll mark the PR as a draft, at least until the design spec is ironed out.

laurenmrice commented 4 weeks ago

Update from design


Image