carbon-design-system / carbon

A design system built by IBM
https://www.carbondesignsystem.com
Apache License 2.0
7.87k stars 1.82k forks source link

[Pagination] Change Select's label to "Page number" #17974

Open alina-jacob opened 3 weeks ago

alina-jacob commented 3 weeks ago

Acceptance criteria


Problem: The screen reader announcement for the pagination component is a bit odd. It potentially announces "of 40 pages" twice. This is the current implementation: Page number of 40 pages, 12

Solution: Implement the label in a way that the screen-reader sounds similar to this: "Page, 12, of 40 pages". PS: Combobox is the assigned role of the component.

Image

preetibansalui commented 1 week ago

Hi @alina-jacob, As discussed, the optimal screen reader announcement in this case will be 1 page number of 11 pages.

We cannot use the format page number 1 of 11 pages, as it would announce the selected page number first, followed by the label.

Please let me know if this works for you.

alina-jacob commented 19 hours ago

Thanks for the update @preetibansalui, we can remove the word "number" to make the content less verbose. So the new expected announcement would be 1, page, of 11 pages