carbon-design-system / carbon

A design system built by IBM
https://www.carbondesignsystem.com
Apache License 2.0
7.87k stars 1.82k forks source link

Fix SelectableTile typescript declaration for "value". #18143

Open wkeese opened 4 days ago

wkeese commented 4 days ago

Closes #16977

I previously fixed PropTypes but forgot to update the Typescript declaration.

Changelog

Changed

Testing / Reviewing

Tested locally.

netlify[bot] commented 4 days ago

Deploy Preview for v11-carbon-web-components ready!

Name Link
Latest commit 6cfd7d7fd1c73abc47683b98b17d32eb21f44a25
Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6740255f2e87dd0008f33f5c
Deploy Preview https://deploy-preview-18143--v11-carbon-web-components.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 4 days ago

Deploy Preview for carbon-elements ready!

Name Link
Latest commit 6cfd7d7fd1c73abc47683b98b17d32eb21f44a25
Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6740255fe2839a00088cda51
Deploy Preview https://deploy-preview-18143--carbon-elements.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 4 days ago

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
Latest commit 6cfd7d7fd1c73abc47683b98b17d32eb21f44a25
Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6740255ff4bba50008e32c61
Deploy Preview https://deploy-preview-18143--v11-carbon-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.87%. Comparing base (626289a) to head (6cfd7d7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #18143 +/- ## ======================================= Coverage 82.87% 82.87% ======================================= Files 404 404 Lines 14338 14338 Branches 4591 4591 ======================================= Hits 11882 11882 Misses 2296 2296 Partials 160 160 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

wkeese commented 4 days ago

As usual, this is getting visual diffs, but presumably they are unrelated to my PR. (Same thing happened on the last PR.)