Open devadula-nandan opened 14 hours ago
Thank you for submitting a feature request. Your proposal is open and will soon be triaged by the Carbon team.
If your proposal is accepted and the Carbon team has bandwidth they will take on the issue, or else request you or other volunteers from the community to work on this issue.
The static icon part of this issue is resolved by #18153. For the the interactive checkbox designs we actually recommend using a popover where the menu requires non-menu actions like shown in the filter. Here is an example in this data table story of the suggested solution for filter menus.
Anna's suggestion is great! I just want to add a point of clarification here. Currently, we have an OverflowMenu Render Custom Icon that uses the Filter icon (or any other icon). I think this creates some confusion.
@janhassel, we should aim for consistency in where specific Overflow Menus will live and consider providing more flexibility—for example, using a popover for the Overflow Menu button within the data table.
@thyhmdo Wouldn't an OverflowMenu with three MenuItemSelectable
work in the shared use case instead of checkboxes inside of a popover?
The problem
Migration from v11 to v12
OverflowMenu
(experimental). doesn't provide an option to render icons inMenuItem
AFAIK.We have an issue in C4IP where
In v11, we utilized the
OverflowMenu
component withOverflowMenuItem
as its child, which supported anitemText
prop that accepted a React node. This allowed us to pass both an icon and text together.To render the checkbox, we implemented a workaround, though it was not ideal, as shown below. This approach needs to be updated to align with Carbon's implementation. However, I could not find an option to achieve the same result with the
MenuItem
component. Do you have any recommendations on how to approach this?In v12 of
OverflowMenu
, theMenuItem
component is used as a child element with properties such aslabel
andshortcut
, both of which are strings. Additionally, therenderIcon
prop does not function as expected onMenuItem
unless the parent component is set tomode='basic'
. However, this configuration is only applicable to theMenu
component and cannot be used withOverflowMenu
.The solution
ability to render checkboxes and icons for v12
OverflowMenu
, like we did in v11.Examples
v11 implementation (go to folder 1 to see 2 overflow menu use cases in action) https://ibm-products.carbondesignsystem.com/?path=/story/ibm-products-patterns-add-and-select-multiaddselect--with-hierarchy&globals=viewport:basic
Application/PAL
c4ip
Business priority
Medium Priority = upcoming release but is not pressing
Available extra resources
No response
Code of Conduct