carbon-design-system / carbon

A design system built by IBM
https://www.carbondesignsystem.com
Apache License 2.0
7.86k stars 1.82k forks source link

Expandable Data Table icon positioning: wrong position in short tables #3053

Closed amitmun closed 5 years ago

amitmun commented 5 years ago

What package(s) are you using?

Detailed description

Describe in detail the issue you're having.

When applying bx--data-table--short to an expandable table, the icon positioning is wrong. See screenshots.

Is this issue related to a specific component?

DataTable

What did you expect to happen? What happened instead? What would you like to see changed?

I would expect the icon to be centered vertically.

What browser are you working in?

Chrome 74.0.3729.169

What version of the Carbon Design System are you using?

10.3.1

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

OD4ICI

Steps to reproduce the issue

  1. Navigate to https://the-carbon-components.netlify.com/?nav=data-table
  2. Scroll down to "Expandable with expand all" example
  3. Add the class "bx--data-table--short" to the expandable table (e.g. using DevTools) so it is like:
  4. The icons will appear too low
  5. Please create a reduced test case in CodeSandbox

    https://codesandbox.io/embed/carbon-components-getting-started-fzcnp

    Additional information

    • Screenshots or code image

    • Notes

    amitmun commented 5 years ago

    2299