search

carbon-design-system / carbon

A design system built by IBM
https://www.carbondesignsystem.com
Apache License 2.0
7.88k stars 1.82k forks source link

Use a more generic Svg wrapper for icons and pictograms #4090

Closed vpicone closed 5 years ago

vpicone commented 5 years ago

Given Icons are a specific thing with different usage guidelines and props than Pictograms, we should rename the hardcoded Icon stuff to be something more inclusive of both components.

The two main concerns are:

  1. An appropriate display name for console errors/debugging/dev tools.
  2. Allowing prop-types to diverge when Icon is able to take a size prop or the components otherwise diverge in behavior
stale[bot] commented 5 years ago

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

stale[bot] commented 5 years ago

As there's been no activity since this issue was marked as stale, we are auto-closing it.