carbon-design-system / carbon

A design system built by IBM
https://www.carbondesignsystem.com
Apache License 2.0
7.76k stars 1.8k forks source link

DataTable with stickyHeader styling of rows and headers regression #6449

Closed guychris closed 4 years ago

guychris commented 4 years ago

What package(s) are you using?

Detailed description

Describe in detail the issue you're having.

The styling with stickyHeader worked as expected in 10.13 / 7.13. CodeSandbox here: https://codesandbox.io/s/carbondatatablestickyheader-03096 , can change the dependency version in the sandbox to 10.15 / 7.15 to see the broken behaviour there as well.

Is this issue related to a specific component?

  • DataTable with stickyHeader prop

What did you expect to happen? What happened instead? What would you like to see changed?

  • Expected styling of header and row cells to be consistent with and without stickyHeader prop set. Would like styling to be restored so there is consistency.

What browser are you working in?

  • Chrome, firefox

What version of the Carbon Design System are you using?

  • issue in 10.14, 10.15 // 7.14, 7.15

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

  • IBM Streams on CPD, a few months of leeway.

Steps to reproduce the issue

  1. Use DataTable with stickyHeader prop.

Please create a reduced test case in CodeSandbox

tw15egan commented 4 years ago

A fix is up over at https://github.com/carbon-design-system/carbon/pull/6452, let me know if that is rendering how you would expect it to 👍

guychris commented 4 years ago

Thanks @tw15egan , that fixes normal tables, but it looks like using expandable rows is broken as well:

https://deploy-preview-6452--carbon-components-react.netlify.app/?path=/story/datatable--with-expansion

image