search

carbon-design-system / carbon

A design system built by IBM
https://www.carbondesignsystem.com
Apache License 2.0
7.6k stars 1.76k forks source link

[new] button set page footer #7004

Open aagonzales opened 3 years ago

aagonzales commented 3 years ago

In the new creation flow we want to componentize the sticky button footer at the bottom of the page. Indicated in the purple box below.

Related: https://github.com/carbon-design-system/carbon/issues/7003 Spec to come.

image

Abdul-Sen commented 3 years ago

Hi @aagonzales Any updates on specs for this issue? Refactoring and componentizing the footer seems like a great way to contribute and I'd love to work on it.

aagonzales commented 3 years ago

@Abdul-Sen Here is a basic spec for the footer. Is this enough to get you started? It would be sticky to the bottom of the page and use the new xl button size

image

Abdul-Sen commented 3 years ago

@aagonzales Thanks, thats great to get started! I'll give it a go and ping if i have any questions. Kindly assign me the issue

tw15egan commented 3 years ago

Thanks for picking it up, @Abdul-Sen! I've assigned you, let me know if you've got any questions.

Abdul-Sen commented 3 years ago

Hello @tw15egan , Thanks for assigning me the task. I searched through the different packages on the monorepo but was not sure which package to add the new compontized footer component. I was unable to find anything about creation flows on the monorepo.

I know there are carbon components under carbon-components-react so it makes sense to add this new component there but they seem to only include base components. Can you please let me know which under package (or storybook) do we expect to see the new component?

tw15egan commented 3 years ago

@Abdul-Sen we'll add the styles needed to /packages/components/src/components/footer and then we add the React logic in /packages/react/src/components/footer

Abdul-Sen commented 3 years ago

Hi @aagonzales , apologise but my IRL work has recently gotten in the way of contributing on this issue. I will have to unassgin myself from the current issue for the time being. Sorry for the inconvenience.