carbon-design-system / carbon

A design system built by IBM
https://www.carbondesignsystem.com
Apache License 2.0
7.76k stars 1.8k forks source link

[Modal] Modal dialog's close button has hard-coded string #8125

Closed cheer021 closed 3 years ago

cheer021 commented 3 years ago
## What package(s) are you using?

Detailed description

Describe in detail the issue you're having.

[Modal] Modal dialog's close button has hard-coded string "Close"

Is this issue related to a specific component?

Modal control https://www.carbondesignsystem.com/components/modal/

What did you expect to happen? What happened instead? What would you like to see changed?

Either

What browser are you working in?

Chrome - this is a cross-browser issue

What version of the Carbon Design System are you using?

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

IBM Cognos Analytics: This issue is not gating our release

Steps to reproduce the issue

  1. Open the Modal dialog
  2. Hover over the close x svg
  3. See "Close"

Additional information

Screen Shot 2021-03-18 at 2 26 51 PM
tw15egan commented 3 years ago

The close button text can be changed via the iconDescription prop

You can test for yourself here, under knobs: https://react.carbondesignsystem.com/?path=/story/components-modal--playground