search

carbon-design-system / carbon

A design system built by IBM
https://www.carbondesignsystem.com
Apache License 2.0
7.86k stars 1.82k forks source link

[Expandable DataTable] - table cell border lines aren't visible enough on hover #8576

Closed jnm2377 closed 1 month ago

jnm2377 commented 3 years ago

What package(s) are you using?

Detailed description

Describe in detail the issue you're having.

In all of our themes, the expandable data table border isn't distinguishable enough when you hover on the expanded row. The hover token should probably be updated for this style (unsure what the new token should be).

What did you expect to happen? What happened instead? What would you like to see changed?

I expected the border to be visibly darker or lighter, depending on the theme.

What browser are you working in?

Chrome

What version of the Carbon Design System are you using?

latest

Additional information

Screen Shot 2021-05-04 at 11 49 04 AM Screen Shot 2021-05-04 at 11 48 54 AM Screen Shot 2021-05-04 at 11 48 40 AM Screen Shot 2021-05-04 at 11 48 26 AM

jnm2377 commented 3 years ago

cc: @carbon-design-system/design any thoughts on this?

aagonzales commented 3 years ago

Lets do adjustLightness(ui-03, -6) for that border on hover. Not sure if that needs to be tied to a token or not. If it does then we need to make a new one.

image

tw15egan commented 3 years ago

🙂 somewhat related 🙃

Wonder if we need to update the zebra hover token?

zebra-hover

carbon-bot commented 1 month ago

Hi there! 👋 You may have seen that v10 reached it's end of support on September 30, 2024. In the interest of keeping a tidy issue queue, issues flagged as relating to v10 will be closed.

If this issue is still relevant, please open a new issue with a link to this issue and a reproduction that uses v11.

Thanks again for your participation and contributions to this issue and the Carbon ecosystem! 💙