search

carbon-design-system / design-language-website

IBM Design Language website
https://www.ibm.com/design/language/
79 stars 217 forks source link

Down state on cards in safari are missing #345

Closed rcwakelin closed 4 years ago

rcwakelin commented 4 years ago

Detailed description

Describe in detail the issue you're having. - See above

What did you expect to happen? What happened instead? What would you like to see changed? - There should not be an outline with the card in the down state

What browser are you working in? Fire Fox

Steps to reproduce the issue

  1. Step one - go to https://www.ibm.com/design/language/elements/typeface in chrome or firefox
  2. Step two - press down on a card there and a blue outline appears Screen Shot 2019-11-18 at 4 57 08 PM
  3. Step three - go to https://www.ibm.com/design/language/elements/ibm-logos/rebus/ in safari
  4. Step two - press down on a card there and no blue outline appears Screen Shot 2019-11-20 at 5 14 47 PM

Additional information

alisonjoseph commented 4 years ago

That's the focus state and needed for accessibility.

rcwakelin commented 4 years ago

@alisonjoseph Lets discuss the color and then apply it consistently across the sites. Its not consistent

rcwakelin commented 4 years ago

@alisonjoseph I cannot recreate were I found the inconsistencies. Agreed lets close.

rcwakelin commented 4 years ago

@alisonjoseph Strike my previous strike! Sadek and I just sat down to review the issue and found this to be a safari issue. Re-wrote headline and story with a better description of what is happening.