Migrate to manifest v3 - Githubissues

carbon-design-system / devtools

A simple set of tools for teams building live Carbon pages.

http://ibm.biz/carbon-devtools

Apache License 2.0

43 stars 18 forks source link

Migrate to manifest v3 #286

Closed erzhan-temir-mamyrov closed 1 year ago

erzhan-temir-mamyrov commented 1 year ago

Closes #84

Add support for Manifest v3

New

Add new package for Manifest v2 (FIrefox issue)

Changed

Update functions in utilities package to support v3
Update main package to support v3

Testing / Reviewing

Navigate to web-extenstion (Manifest v3) or web-extension-v2 (Manifest v2) package and run yarn watch or yarn build.
Setup Chrome (v3) / Firefox (v2) browser with custom extension.
Open any website built using Carbon.
Verify Devtools functionality.

erzhan-temir-mamyrov commented 1 year ago

Reviewers: @motou

motou commented 1 year ago

Nice job! 👍 Already checked with https://developer.chrome.com/docs/extensions/mv3/mv3-migration/

motou commented 1 year ago

Looks so far so good from the code changes. Please adjust the Github action file to make sure that the correct version is published to different stores:

https://github.com/carbon-design-system/devtools/blob/base/.github/workflows/publish.yml

erzhan-temir-mamyrov commented 1 year ago

@motou Thank you very much for the feedback! I corrected pipeline according to new changes.

motou commented 1 year ago

Awesome👍thanks for your contribution! @erzhan-temir-mamyrov

erzhan-temir-mamyrov commented 1 year ago

@motou Thank you for the support! I am wondering which issue I could tackle next, or I could pick up any from the list? I guess bugs have higher priority than enhancements.