fix(scss): import + other minor fixes

carbon-design-system / gatsby-theme-carbon

A Carbon inspired Gatsby theme

https://gatsby.carbondesignsystem.com/

Apache License 2.0

359 stars 275 forks source link

fix(scss): import + other minor fixes #1410

Closed muditjuneja closed 9 months ago

muditjuneja commented 9 months ago

This PR aims at fixing a few things that are causing build failures which include -

Mdx updated format
Fix a few imports as per the upgrades

This PR should be merged to the next branch.

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
gatsby-theme-carbon	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 6, 2024 3:26pm

muditjuneja commented 9 months ago

@eng618 Can you review this PR?

muditjuneja commented 9 months ago

@eng618 useMetadata was not being called in DefaultLayout and it was not able to supply the theme variables. Fixed it by calling the method. Another thing that I am noticing is that the Code component is not working as expected and we would need to look more into that. Other than this, build looks good.

muditjuneja commented 9 months ago

Also, Text defined like below -

The <ResourceCard> component should be wrapped with a <Column> inside of <Row className="resource-card-group"> or <Row className="resource-card-group-3-across">. This allows the correct border placement between a group of cards spanning 2 or 3 across.

is being rendered differently in the new version and the older live build. See the diff below