carbon-design-system / gatsby-theme-carbon

A Carbon inspired Gatsby theme
https://gatsby.carbondesignsystem.com/
Apache License 2.0
359 stars 275 forks source link

Fix: code blocks in mdx + issues/868 #1422

Closed muditjuneja closed 8 months ago

muditjuneja commented 9 months ago

This PR fixes the following -

Should close - https://github.com/carbon-design-system/gatsby-theme-carbon/issues/868

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gatsby-theme-carbon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 2, 2024 10:36pm
muditjuneja commented 9 months ago

Hi @eng618 can you review this PR?

netlify[bot] commented 9 months ago

Deploy Preview for gatsby-theme-carbon ready!

Name Link
Latest commit 9ce6a1e29382f1a0f3981c67c9bf252f4887a9d9
Latest deploy log https://app.netlify.com/sites/gatsby-theme-carbon/deploys/65e3a93a0e4b5e0009a7cc93
Deploy Preview https://deploy-preview-1422--gatsby-theme-carbon.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

eng618 commented 9 months ago

Also take a look at https://gatsby.carbondesignsystem.com/components/code-blocks this is the behavior we should see. Seems like instead of have horizontal scrolling we are automatically wrapping the lines.

Then for the folding one we should have the example of non folding and folding vertically.

eng618 commented 9 months ago

Lets add some padding to the show more button so it doesn’t overlap the content.

image
muditjuneja commented 8 months ago

Lets add some padding to the show more button so it doesn’t overlap the content.

image

I will do that in another follow up PR. Merging this one now.

muditjuneja commented 8 months ago

Lets add some padding to the show more button so it doesn’t overlap the content.

image

I will do that in another follow up PR. Merging this one now.

I guess I can't merge. I will make that small change.