search

carbon-design-system / gatsby-theme-carbon

A Carbon inspired Gatsby theme
https://gatsby.carbondesignsystem.com/
Apache License 2.0
358 stars 273 forks source link

Fix(hideCode) - Checking for stringified boolean #1444

Closed muditjuneja closed 7 months ago

muditjuneja commented 7 months ago

This PR fixes how hideCode prop is handled as a string value.

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gatsby-theme-carbon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 8:39pm
netlify[bot] commented 7 months ago

Deploy Preview for gatsby-theme-carbon ready!

Name Link
Latest commit 7155fe6da6fbc4105943921dda83c47eb349cacb
Latest deploy log https://app.netlify.com/sites/gatsby-theme-carbon/deploys/65f20e58a306a200083d639d
Deploy Preview https://deploy-preview-1444--gatsby-theme-carbon.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

alisonjoseph commented 7 months ago

@muditjuneja I pulled your change into https://github.com/carbon-design-system/gatsby-theme-carbon/pull/1443 FYI CI will fail if you don't use the correct commit conventions.

muditjuneja commented 7 months ago

My bad, Sometimes I forget that commit lint is present here.