Review Image Padding in Style Tab for Consistency

carbon-design-system / gatsby-theme-carbon

A Carbon inspired Gatsby theme

https://gatsby.carbondesignsystem.com/

Apache License 2.0

359 stars 274 forks source link

Review Image Padding in Style Tab for Consistency #1488

Closed Kritvi-bhatia17 closed 1 month ago

Kritvi-bhatia17 commented 8 months ago

The Style page images with tab functionality seem to have an extra margin at the bottom, causing the images to appear slightly uneven.

[ ] Review the padding for both the top and bottom to determine its necessity.

tay1orjones commented 8 months ago

This style is coming from the gatsby theme. We might want to consider removing the padding somehow if an image is placed in the tab.

divya-281 commented 6 months ago

Hi @alisonjoseph I would like to work on this issue. Please assign this to me.

alisonjoseph commented 6 months ago

@divya-281 this issue would need to be addressed upstream in the https://github.com/carbon-design-system/gatsby-theme-carbon. We also need a specific design spec to complete this.

This is the component affected. https://gatsby-theme-carbon.vercel.app/components/Tabs

Kritvi-bhatia17 commented 4 months ago

Hi @sstrubberg, could you please clarify what design specifications are needed for this issue? Thank you!

alisonjoseph commented 1 month ago

@Kritvi-bhatia17 For the design spec we will need to know the padding and background color.

For example do we want 1rem padding all the way around with a white background, or zero padding with no background.

Kritvi-bhatia17 commented 1 month ago

Hi @alisonjoseph, could you please confirm if there’s any padding applied to the images without the tab? (From what I see, there doesn’t seem to be any padding for images without tabs, but I just wanted to double-check with you.)

Kritvi-bhatia17 commented 1 month ago

Hi @alisonjoseph, I discussed with the team, and we’ve finalized that it would be best to go with zero padding and include a white background for the images with tabs. Please let me know if you need any further help, thank you!

aagonzales commented 1 month ago

I think we need to review this in crit next week @Kritvi-bhatia17. As mentioned this is a gatsby theme components and websites other than our main carbon website use this component. This padding was intentionally added to this component. If anything we may want to create a new variant without the padding and still leave the option of having the padding.

This issue is not a bug because it's showing as originally intended. This is an enhancement issue.

jeanservaas commented 1 month ago

WE ARE NOT DOING ANY GATSBY ENHANCEMENTS AS A GENERAL RULE.

Kritvi-bhatia17 commented 1 month ago

Got it, @jeanservaas and @aagonzales! I wasn’t aware of it, but thanks for the clarification!