search

carbon-design-system / gatsby-theme-carbon

A Carbon inspired Gatsby theme
https://gatsby.carbondesignsystem.com/
Apache License 2.0
358 stars 273 forks source link

Tree nav: tabs do not always get highlighted in nav #1504

Closed matthewgallo closed 1 month ago

matthewgallo commented 2 months ago

Detailed description

Describe in detail the issue you’re having.

Pages in tree nav can lose highlighting in the left nav. With this page for example, the overview page receives the expected highlighting, however, the other pages lose highlight and the nav collapses. This causes the user to lose context as to where they are.

https://ibm-products-website.carbondesignsystem.com/patterns/canvases/nodes/card-nodes/ https://ibm-products-website.carbondesignsystem.com/patterns/canvases/nodes/shape-nodes/ https://ibm-products-website.carbondesignsystem.com/patterns/canvases/nodes/bullet-nodes/

What did you expect to happen? What happened instead? What would you like to see changed?

Expected the navigation to not collapse and to also not collapse.

What browser are you working in?

Chrome

Steps to reproduce the issue

  1. Can reproduce with example pages above
elycheea commented 2 months ago

From when I was looking at the original PR, thinking this might be due to the way we’re setting location/path name.

elycheea commented 2 months ago

Also noticed that the About/Overview collapses when you first go to the Overview tab. https://ibm-products-website.carbondesignsystem.com/about/overview/