Closed elycheea closed 10 months ago
• Explore examples from Google sheets and Excel around keyboard accessibility for resizable columns, investigate more regarding DataSpreadsheet usage vs Datagrid inline edit) • Think about how keyboard focus state works with sorting and other potential focusable elements in the column header • Potentially have the focusable resizer/sorting use some kind of keyboard shortcut to remove it from the default focus order
@Ratheeshrajan Matt’s already been involved in the initial design reviews for these issues. While he’s out, I think you’re the best person to help close out these issues.
@vsnichols @johanna-koval Wanted to follow up on some of the comments from the design review.
DataSpreadsheet
over a Data table
though.I do think it’d be worth considering “modes” to limit confusing keyboard interactions though. When we met with @mbgower, he emphasized importance of time on task and equivalent facilitation. If sortable columns in combination with resize makes the keyboard interactions feel clunky, it might be worth creating some constraints around it. e.g. Don’t enable both sorting and resize simultaneously or toggle these via modes. (One of the suggestions was leveraging the settings menu, which currently is just used for row height settings.)
Happy to discuss these further, but I’ll open an issue in the meantime so we can get the tabbable sorting from Carbon added to play with alongside the resize prototype.
FYI @Ratheeshrajan A prototype of the resizable columns with keyboard actions is in this draft PR if you’d like to either take over the PR or build off it. https://github.com/carbon-design-system/ibm-cloud-cognitive/pull/2464
@johannasuarez-koval
Most of the columns can be shrunk to the min size, making the data in them disappear completely. we should always reveal a minimum of one letter in each cell.
I think I get it, the header's hover state is set to a certain size. If the column is wider than the max, the hover state's color defaults to a different hover color.
Some columns won't hide the data if shrunk to min (Joined column)
From the Resizing columns section Wasn't able to utilize these two features: (i) Resizing multiple columns at once and (ii) Resize column to fit its content.
On Mac, If I hold the ctrl button while clicking the header's resize option and then let go of the ctrl button and left click, the resize column behavior is initiated and follows my mouse's movement. Canceled only on left click.
Design review
Standards
Pattern and behavior
Storybook