carbon-design-system / ibm-products

A Carbon-powered React component library for IBM Products
https://ibm-products.carbondesignsystem.com
Apache License 2.0
98 stars 138 forks source link

Add skeletons for Datagrid title and primary actions #3283

Closed elycheea closed 1 day ago

elycheea commented 1 year ago
          We actually have our own custom skeleton for the table, it is built via the `useSkeletonRows` hook [here](https://github.com/carbon-design-system/ibm-products/blob/main/packages/ibm-products/src/components/Datagrid/useSkeletonRows.js). I noticed some differences in the screenshot @sdignum shared above compared to ours, particularly:

Originally posted by @matthewgallo in https://github.com/carbon-design-system/ibm-products/issues/3120#issuecomment-1641053823

elycheea commented 1 year ago

Low priority should leave for contribution.

ArslanYM commented 1 year ago

Can i work on this?

ljcarot commented 1 day ago

We've been investigating TanStack Table, a third-party, open-source offering, which provides extensive data table capabilities surpassing what our Carbon Datagrid offers. It provides much more flexibility and customization. TanStack Table is headless which means it can easily be added alongside Datagrid component in your product or application. The benefits of more flexibility for product teams and less maintenance for Carbon makes it a win win. Lastly, it is available in multiple frameworks including React and Web Component so it provides an option to non-React product teams.

For these reasons, we have decided to transition from building our own custom table component to using an example-based approach with TanStack Table. Datagrid will still exist in our library for existing teams but we are announcing the deprecation* of the Datagrid component in v2.54.0 release so teams can begin to work through the transition. Details about how to use both Datagrid and TanStack together can be found here.

*Deprecation means that no new features will be added however sev 1 and sev 2 bugs will be supported.