search

carbon-design-system / ibm-products

A Carbon-powered React component library for IBM Products
https://ibm-products.carbondesignsystem.com
Apache License 2.0
98 stars 138 forks source link

Stop shipping your test material? #3382

Open s100 opened 1 year ago

s100 commented 1 year ago

What package(s) are you using?

(I am never sure which category @carbon/ibm-cloud-cognitive-cdai is supposed to fit in...)

Detailed description

Describe in detail the issue you're having.

In the install tree for @carbon/ibm-cloud-cognitive-cdai I see numerous test files, from es/component_helpers/A11yHelper.spec.js to es/components/IdeAPIKeyGeneration/IdeAPIKeyGeneration.cucumber.js to lib/globals/js/settings.spec.js. You are also shipping something called jest_test_helper_functions.js, and StorybookHelper.js, and various _storybook.scss files.

I'm fairly sure you don't intend to ship these, as they increase build times, install times and disk footprint. I tried removing them, and this reduced the size on disk of this package by more than two-thirds, from 1.50MB to 466kB.

Is this issue related to a specific component?

No.

What did you expect to happen? What happened instead? What would you like to see changed?

I feel like "Describe in detail the issue you're having" already covers this? Not sure why you ask the same question twice.

What browser are you working in?

N/A

What version of the @carbon/ibm-products (or @carbon/ibm-cloud-cognitive) package are you using?

1.24.6

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

N/A

Steps to reproduce the issue

OK and now you're asking the same question a third time for some reason!

Additional information

N/A

elycheea commented 1 year ago

Tagging @asfordmatt and @vladbalanescu but would probably recommend creating a PR for fastest resolution.