search

carbon-design-system / ibm-products

A Carbon-powered React component library for IBM Products
https://ibm-products.carbondesignsystem.com
Apache License 2.0
94 stars 137 forks source link

Web Terminal Content conflicts with UIShell Content #3418

Open lee-chase opened 1 year ago

lee-chase commented 1 year ago

In attempting to fix the Web Terminal docs page (where the story is shown) use of a Carbon Content component caused the page to be 100vh + 3rem in height. This should not happen, fix was not applied.

It should be possible to use the Web Terminal in conjunction with UIShell header and content components without the page height/width exceeding the bounds of the screen. The example should show this and reserve vertical space for the example.

elycheea commented 1 year ago

Most likely will provide a breaking change ... or incorporate some feature flags to make this work properly with UI shell.