carbon-design-system / ibm-products

A Carbon-powered React component library for IBM Products
https://carbon-for-ibm-products.netlify.app/
Apache License 2.0
87 stars 126 forks source link

Full-page errors #4009

Open elycheea opened 5 months ago

elycheea commented 5 months ago

Full page errors

Brief description

Display a full-page error when the requested page is unavailable to the user. This is typically caused by issues with the requested URL or access permissions. Errors caused by server connectivity issues are not covered in this guideline.

Details

This pattern is intended to replace the current version of HTTP errors.

Link to design Current version (3 variants — 403, 404, other)

Links to other materials

e.g. sketch files, icons, images, prototypes

Design Maintainer(s)

Tasks

Before starting work on this epic, please review and complete the following.

Working in Carbon for IBM Products package

### Acceptance criteria
- [ ] https://github.com/carbon-design-system/ibm-products/issues/4075
- [ ] https://github.com/carbon-design-system/ibm-products/issues/4080
- [ ] https://github.com/carbon-design-system/ibm-products/issues/4138
- [ ] https://github.com/carbon-design-system/ibm-products/issues/4081
- [ ] https://github.com/carbon-design-system/ibm-products/issues/4402
- [ ] https://github.com/carbon-design-system/carbon-for-products-design-kit/issues/23
- [ ] https://github.com/carbon-design-system/ibm-products/issues/5050
### Review process
- [ ] #4434
- [ ] #4435
- [ ] #4439
- [ ] https://github.com/carbon-design-system/ibm-products/issues/4083
elycheea commented 5 months ago

Given @davidmenendez’s recent refactor of empty state, I would suggest that we set a call with at least @thefirstartist @davidmenendez to define the acceptance criteria for this issue.

elycheea commented 3 months ago

@devadula-nandan Not that I was expecting to see many issues with full-page errors, but happy to share that accessibility review passed with only one non-blocking issue! Assigned to you but don’t think you need to address it right away either since it’s a lower priority cleanup. We have the tiniest bit of redundant code in Storybook. 🙂