carbon-design-system / ibm-products

A Carbon-powered React component library for IBM Products
https://ibm-products.carbondesignsystem.com
Apache License 2.0
98 stars 138 forks source link

Refactor ActionSet to use container queries #4164

Open elycheea opened 9 months ago

elycheea commented 9 months ago

Move all the behavior to the ActionSet and use container queries to update the layout. This will lead to a slight head scratcher in SidePanel where the width of the use of a 1px left border and box-sizing border box (hint the width of the ActionSet on a 2xl SidePanel is 2xl - 1.

Originally posted by @lee-chase in https://github.com/carbon-design-system/ibm-products/issues/4019#issuecomment-1910605445

elycheea commented 9 months ago

ActionSet is used in Tearsheet, CreateFullPage, FilterFlyout, FilterPanel, SidePanel.

elycheea commented 9 months ago

Maybe @cameroncalder @Laura-Marshall or @My-Money29 can help with reviewing this once in deploy preview.

lee-chase commented 9 months ago

We have Action set used in a number of places.

The following behavior is either a inconsistent or not achievable without DOM manipulation. DOM manipulation is problematic when using LIT to construct web components.

Use cases

lee-chase commented 9 months ago

@cameroncalder @Laura-Marshall @My-Money29 I'm thinking of making the buttons in all cases stack like the SidePanel version when narrow. Any objections before I jump into coding this?

Laura-Marshall commented 9 months ago

From what I can gather from this thread, having the buttons stack when things become small across the board makes sense to me.

elycheea commented 9 months ago

Should evaluate whether we can replace the ActionSet with ButtonSet.

ljcarot commented 2 months ago

@elycheea what is status of this work?

elycheea commented 2 months ago

@ljcarot On hold. I believe @lee-chase did some exploration and prototyping for this work on the Core repo as well using ButtonSet. It might still be good to do some evaluation to see if we can fully replace ActionSet with ButtonSet to reduce duplication. (Probably track in a separate issue though.)

oliviaflory commented 6 days ago

@elycheea @davidmenendez should this be wrapped into the Utilities issue for action set and all the other overflow like items we identified?