carbon-design-system / ibm-products

A Carbon-powered React component library for IBM Products
https://carbon-for-ibm-products.netlify.app/
Apache License 2.0
87 stars 120 forks source link

feat(TagOverflow): new component TagOverflow #4535

Closed szinta closed 2 months ago

szinta commented 3 months ago

Contributes to #4086

New TagOverflow component to extend the functionality of existing TagSet component to other types of UI elements such as UserAvatar, custom react components etc.

What did you change?

How did you test and verify your work?

netlify[bot] commented 3 months ago

Deploy Preview for carbon-for-ibm-products ready!

Name Link
Latest commit 55f4bb88c9131903893c8e1d184f6fcdce6639e4
Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/660e4d7dac13fd000832f20c
Deploy Preview https://deploy-preview-4535--carbon-for-ibm-products.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 3 months ago

DCO Assistant Lite bot All contributors have signed the DCO.

szinta commented 3 months ago

I have read the DCO document and I hereby sign the DCO.

szinta commented 2 months ago

@davidmenendez I have implemented all the review comments. Please have a look.

davidmenendez commented 2 months ago

looks good! thanks for making those changes. i think the only thing left is that small point that elysia pointed out regarding the default tag color 👍

davidmenendez commented 2 months ago

@sintaibm when you get a chance can you also provide your environment details? i was thinking about that cspell issue and i don't know why it wasn't caught on your initial commit. the typo should have prevented the commit from happening. this is something i've been trying to investigate, so if you could provide information about your environment like node version, yarn version, OS, etc that would be super helpful!

szinta commented 2 months ago

looks good! thanks for making those changes. i think the only thing left is that small point that elysia pointed out regarding the default tag color 👍

Done. Please have a look

szinta commented 2 months ago

@sintaibm when you get a chance can you also provide your environment details? i was thinking about that cspell issue and i don't know why it wasn't caught on your initial commit. the typo should have prevented the commit from happening. this is something i've been trying to investigate, so if you could provide information about your environment like node version, yarn version, OS, etc that would be super helpful!

I think the pre-commit hooks aren't working for me. I don't see any commitlint / lint-staged logs or errors while committing my changes. To see the cspell errors, I had to manually run the command yarn spellcheck. I could see approximately 115 cspell errors in 31 files, indicating that these pre-commit hooks are not working for some other developers as well.

Please find my environment details below: Node version - v18.19.0 Yarn - 4.0.2 OS - macOS Sonoma 14.3.1

szinta commented 2 months ago

@all-contributors please add @szinta for code

allcontributors[bot] commented 2 months ago

@szinta

I've put up a pull request to add @szinta! :tada: