carbon-design-system / ibm-products

A Carbon-powered React component library for IBM Products
https://carbon-for-ibm-products.netlify.app/
Apache License 2.0
87 stars 120 forks source link

fix: adds short text option for pageheader #4562

Closed davidmenendez closed 3 weeks ago

davidmenendez commented 3 months ago

Contributes to #4323

adds an optional shortText prop that can be used instead of label when a breadcrumb is particularly long. also some slight cleanup.

netlify[bot] commented 3 months ago

Deploy Preview for carbon-for-ibm-products ready!

Name Link
Latest commit d4921adcd9961a1d2265a383b682a5897ddc6c05
Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6646394bd146b70008ad00d4
Deploy Preview https://deploy-preview-4562--carbon-for-ibm-products.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

davidmenendez commented 2 months ago

@elycheea thanks for the comments. i didn't realize we exposed BreadcrumbWithOverflow which exposed a problem with my fix. will continue to work on this.

davidmenendez commented 2 months ago

@elycheea ready for re-review

davidmenendez commented 1 month ago

@elycheea sorry i missed that last comment.

fixt 👍

elycheea commented 1 month ago

@davidmenendez Haha, I think my comment was for PageHeader but latest change was in BreadcrumbWithOverflow? 👀 Small change either way though! You might be able to commit the suggestion as is if it makes sense to you too though.

davidmenendez commented 1 month ago

@elycheea apologies for the mix up! changes pushed

davidmenendez commented 1 month ago

@elycheea fixt 4 real

davidmenendez commented 1 month ago

@elycheea thanks for catching that. updated

makafsal commented 1 month ago

@elycheea @davidmenendez My changes are there, looks good 👍