Closed davidmenendez closed 3 weeks ago
Name | Link |
---|---|
Latest commit | d4921adcd9961a1d2265a383b682a5897ddc6c05 |
Latest deploy log | https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6646394bd146b70008ad00d4 |
Deploy Preview | https://deploy-preview-4562--carbon-for-ibm-products.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@elycheea thanks for the comments. i didn't realize we exposed BreadcrumbWithOverflow
which exposed a problem with my fix. will continue to work on this.
@elycheea ready for re-review
@elycheea sorry i missed that last comment.
fixt 👍
@davidmenendez Haha, I think my comment was for PageHeader but latest change was in BreadcrumbWithOverflow? 👀 Small change either way though! You might be able to commit the suggestion as is if it makes sense to you too though.
@elycheea apologies for the mix up! changes pushed
@elycheea fixt 4 real
@elycheea thanks for catching that. updated
@elycheea @davidmenendez My changes are there, looks good 👍
Contributes to #4323
adds an optional
shortText
prop that can be used instead of label when a breadcrumb is particularly long. also some slight cleanup.