search

carbon-design-system / ibm-products

A Carbon-powered React component library for IBM Products
https://carbon-for-ibm-products.netlify.app/
Apache License 2.0
88 stars 126 forks source link

Identifying subcomponents #4683

Closed ljcarot closed 1 month ago

ljcarot commented 3 months ago

Breaking down the pattern into subcomponents (dev & design) e.g. drawer, cards.

### Tasks
- [x] Investigate if we need another size for the selectable tags or if these are just examples for flow
elycheea commented 3 months ago

Notes from Apr 5, 2024

Item 6 from anatomy ... seems very similar to radio button or progress indicator except not necessarily continuous steps. Feels like a new state for “visited” or “completed” — feels selectable. — @mbgower Should see if we can explore other ways to communicate the status in this case.

Think we can probably start refining just the getting started card variants. Bridget’s already broken these down well enough so far.

@elycheea to reach out to @jlongshore if there’s any additional context we need on using this with WalkMe. Edit: Don’t think this should impact how we build the components since other onboarding components in our library are also used with the SDK.

elycheea commented 3 months ago

@mbgower @kingtraceyj Also remembered after chatting with Jeff that the Checklist also uses a similar style to indicate “status.” We discussed tags with text during our call but can see the continuity with the Checklist component too.

elycheea commented 2 months ago

@ljcarot I think selectable tags are part of the new tags Lauren’s been sharing so I think we can remove that from the list.

Looks like drawer is taking shape as a component/variant but probably still a question where it lives (core, products).

@kingtraceyj where do we want to put the issue for the work you’re doing now so we can at least track it on the board?

ljcarot commented 2 months ago

@kingtraceyj or @oliviaflory Sounds like we want a new issue for Design related to the vertical tabs and related design decisions. Is that correct? If we do that, do we close this issue?

elycheea commented 2 months ago

Can probably close this issue once we open an issue in Core for vertical tabs. @kingtraceyj to share issue and close this one once created.

kingtraceyj commented 2 months ago

@elycheea tracking specs here: https://github.com/carbon-design-system/carbon/issues/16297

kingtraceyj commented 2 months ago

@elycheea opened the dev ticket for tabs here! https://github.com/carbon-design-system/carbon/issues/16305

i still need to tie up a few loose ends but i think were 90% of the way there.