Closed matthewgallo closed 2 weeks ago
Name | Link |
---|---|
Latest commit | 29080a418ed0c4bb28a4c85f0af41b638a6900f0 |
Latest deploy log | https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6638d6572dae6300082e9d5f |
Deploy Preview | https://deploy-preview-4987--carbon-for-ibm-products.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Closes #4986 Closes #4946
This PR moves our storybook builds from
webpack
tovite
. This includes significant performance improvements for both startup times and build times.Moving to
vite
required renaming all story files to use.jsx
and appending?inline
to the imported style file for each story that has one (this is the only way to include a default import of a style file invite
, see here for more details).We were able to remove several
babel
andwebpack
packages frompackages/core/package.json
with this change. Another part that is included in this PR is removing thestorybook-carbon-addon-theme
. It's been replaced with a similar approach to Carbon, theme can be changed from top toolbar.What did you change?
Storybook config files Renamed all story files from
.stories.js
to.stories.jsx
How did you test and verify your work?
Verified that running storybook locally works and storybook can also be built as expected (
yarn storybook:build
).Storybook startup after move to
vite
~1 sec