search

carbon-design-system / ibm-products

A Carbon-powered React component library for IBM Products
https://carbon-for-ibm-products.netlify.app/
Apache License 2.0
83 stars 116 forks source link

fix: Return focus to launcher button #5017

Open makafsal opened 2 weeks ago

makafsal commented 2 weeks ago

Contributes to #5014

What did you change?

Implemented launcherButtonRef in both Tearsheet and SidePanel components

How did you test and verify your work?

Storybook

netlify[bot] commented 2 weeks ago

Deploy Preview for carbon-for-ibm-products ready!

Name Link
Latest commit a4c4b33601e61844549c1db72382dc0ba81332e5
Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6646ecb5374f4d00082d377c
Deploy Preview https://deploy-preview-5017--carbon-for-ibm-products.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

makafsal commented 1 week ago

this looks good. can you include this change in a storybook story so the functionality can be demonstrated?

@davidmenendez Included in storybook.

makafsal commented 12 hours ago

@davidmenendez Added test for both SidePanel and Tearsheet.