search

carbon-design-system / ibm-products

A Carbon-powered React component library for IBM Products
https://carbon-for-ibm-products.netlify.app/
Apache License 2.0
89 stars 127 forks source link

sidepanel refactor #5023

Open davidmenendez opened 2 months ago

davidmenendez commented 2 months ago

while trying to address #4966 i took a closer look at SidePanel and i think it needs to be cleaned up. Namely it needs to be broken up into separate component pieces like body, footer, header, etc. there's too much going on in this single file and too much logic is present in the HTML

additionally the click outside functionality needs to be looked at. in #4968 i implemented a hook to check the user preference for reduced motion, but for some reason SidePanel is the only component that was having an issue with it. i suspect it's because there's something funky going on with the various effects going on here. these effects should also be looked at and cleaned up.

ljcarot commented 2 months ago

@davidmenendez We talked about this in the workshop. This issue may be replaced with an Epic in carbon core. In other words, don't take on the refactor yourself as we have bigger plans for this guy.