search

carbon-design-system / ibm-products

A Carbon-powered React component library for IBM Products
https://ibm-products.carbondesignsystem.com
Apache License 2.0
92 stars 136 forks source link

React 19: `createContext` requires an argument #5039

Open matthewgallo opened 4 months ago

matthewgallo commented 4 months ago

What will this achieve?

Similar to https://github.com/carbon-design-system/ibm-products/issues/5038, this issue is specific to updating all usage of createContext in order to become compatible with React 19.

### Components using `createContext` without an argument
- [ ] `Coachmark/utils/context.js`
- [ ] `ConditionBuilder/ConditionBuilderContext/DataTreeContext.js`
- [ ] `Datagrid/addons/Filtering/FilterProvider.js`
- [ ] `Datagrid/addons/InlineEdit/InlineEditContext.js`
- [ ] `WebTerminal/hooks/index.js`
- [ ] `scripts/example-gallery-builder/update-example/templates/src/ThemeSelector/ThemeContext.jsx`
elycheea commented 2 months ago

@matthewgallo Have we added all the affected components, and is this ready for backlog?

matthewgallo commented 1 month ago

Yes it should be ready for backlog now. Sorry, I missed your comment here!