search

carbon-design-system / ibm-products

A Carbon-powered React component library for IBM Products
https://ibm-products.carbondesignsystem.com
Apache License 2.0
94 stars 137 forks source link

Upgrading @carbon/react to 1.57 causes infinite loop in Datagrid ( #5403

Closed lee-chase closed 2 months ago

lee-chase commented 4 months ago

Package

Carbon for IBM Products

Description

Updating my prototype to Carbon/React 1.57.0 causes an infinite loop in the datagrid.

If I comment out this it works. <FilterFlyout {...getFilterFlyoutProps()} />

Component(s) impacted

Datagrid

Browser

Chrome

@carbon/ibm-products (previously @carbon/ibm-cloud-cognitive) version

2.41.0

Severity

Severity 1 = The design is broken in a critical way that blocks users from completing tasks or damages the brand. Affects major functionality, no workaround.

Product/offering

N/A

CodeSandbox or Stackblitz example

N/A

Steps to reproduce the issue (if applicable)

Internal prototype link can be provided for investigation.

Release date (if applicable)

No response

Code of Conduct

matthewgallo commented 4 months ago

Hey @lee-chase, are you using the MultiSelect filter by chance? I am able to replicate this bug after upgrading Carbon, but only if the MultiSelect filter is being used in either the filter panel or flyout. Just trying to narrow this down.

matthewgallo commented 4 months ago

Could you also share what filters you're including in the flyout? If you could provide a code sandbox/stackblitz even better 😄

matthewgallo commented 3 months ago

Stems from https://github.com/carbon-design-system/carbon/issues/16469 which looks to be resolved. I'll update our version of @carbon/react when this fix has been included in a release.

elycheea commented 3 months ago

Moving this to sprint 21 for now to try to time the next @carbon/react version + next dependency updates.

Ashley-Johnson28 commented 3 months ago

Do we know a timeline when the data grid will be fixed? Our team is hoping to implement the filter flyout with multi select with our newest feature and could be blocked by this.

matthewgallo commented 3 months ago

Hey @Ashley-Johnson28, we've been waiting for a new release from @carbon/react as the root cause here was from the MultiSelect component. I've opened a PR to use the latest version that will fix this issue. With the upcoming holiday my guess is that it will be reviewed/merged next week.