carbon-design-system / ibm-products

A Carbon-powered React component library for IBM Products
https://ibm-products.carbondesignsystem.com
Apache License 2.0
94 stars 137 forks source link

TagSet overflow does not appear when in Datagrid #5407

Closed csamarchi closed 3 weeks ago

csamarchi commented 4 months ago

Package

Carbon for IBM Products

Description

The expected behavior is when user clicks on the Tagset button to see more tags, the overflow menu should appear with listed tags. Instead, you click, and nothing appears.

Screenshot 2024-05-29 at 11 01 17 AM

https://github.com/carbon-design-system/ibm-products/assets/42501494/6a1b9cc9-7a42-4a26-8d9c-e3ae654b356c

tagsetoverflow

Component(s) impacted

TagSet, Datagrid, SidePanel, & SidePanelContainer

Slack conversation here

Code snippet: Screenshot 2024-05-29 at 11 02 33 AM

TagSet docs here

Browser

Chrome

@carbon/ibm-products (previously @carbon/ibm-cloud-cognitive) version

v^1.72.2

Severity

Severity 2 = Aspects of design is broken, and impedes users in a significant way, but there is a way to complete their tasks. Affects major functionality, has a workaround.

Product/offering

Projects-ui

CodeSandbox or Stackblitz example

https://stackblitz.com/edit/github-q7ndbt?file=src%2FExample%2FExample.jsx

Steps to reproduce the issue (if applicable)

  1. Click into SidePanel
  2. Find Tags +n in Datagrid
  3. Click +n
  4. Overlay should show

Release date (if applicable)

No response

Code of Conduct

davidmenendez commented 4 months ago

i have confirmed this behavior is appearing in C4P v1 as well as v2 and it appears to be confined to overflow within the context of a datagrid

csamarchi commented 4 months ago

Is there any possibility we can get this fix into v1? We don't have the capacity right now to update our entire codebase to Carbon11

elycheea commented 1 month ago

@csamarchi Unfortunately with EOS for Carbon 10 coming up in September, we will not be adding this fix for v1. If you need assistance with a workaround, you’re welcome to join one of our upcoming office hours. Our next one is the first week of September.

davidmenendez commented 3 weeks ago

hey @csamarchi a fix has been issued to resolve this bug and should be available in our next release.

if you look at the fix PR all you need to do is use the new autoAlign functionality in TagSet to alleviate the visual bug