carbon-design-system / ibm-products

A Carbon-powered React component library for IBM Products
https://ibm-products.carbondesignsystem.com
Apache License 2.0
92 stars 136 forks source link

Need enhancement in Filtering component of Carbon IBM Products DataGrid #5633

Open Nishi-Chandra1 opened 2 months ago

Nishi-Chandra1 commented 2 months ago

The problem

For each type of filter inputs (RadioButton, Dropdown, MultiSelect) given under Filter props there is 'Any' option present by default . Based on my design requirement, i don't want to show this 'Any' option. I cannot see any prop present in storybook which will help to remove this 'Any' option. Even if i am trying to remove 'Any' option via 'DefaultRadioButton' prop available for RadioButton, the click events are not behaving properly. Every time on change of radio button click, its navigating to 'Any' and then coming back to clicked option. I need to click on radio 2 times for it to get selected.

The solution

'Any' option should not be present by default for all the filter options. It should be based on input type provided by user.

Design link

https://carbon-for-ibm-products.netlify.app/?path=/docs/ibm-products-components-datagrid-filtering-panel--docs#component-api

Links to other materials

No response

Owner/main maintainer(s)

Nishi Chandra

Second/backup maintainer(s)

No response

Product/offering

IBM AI Security

Business priority

Medium Priority = upcoming release but is not pressing

Code of Conduct

elycheea commented 1 month ago

Should share this case with the filtering workgroup. @carrenelloyd to connect these. Or attend the next Carbon design office hours.

davidmenendez commented 1 month ago

filtering workgroup will be investigating 👍

github-actions[bot] commented 2 weeks ago

This issue is stale because it has been open for 30 days with no activity. Remove the stale label or add a comment, otherwise this issue will be closed in 14 days.

carrenelloyd commented 1 week ago

Bot don't close

davidmenendez commented 1 week ago

thank you @carrenelloyd !