carbon-design-system / ibm-products

A Carbon-powered React component library for IBM Products
https://ibm-products.carbondesignsystem.com
Apache License 2.0
97 stars 138 forks source link

[CUSTOMIZE COLUMNS BUG]: If all the columns are unchecked, Save button should not be enabled #5843

Closed Xirax closed 1 month ago

Xirax commented 2 months ago

Package

Carbon for IBM Products

Description

If I click on Customize Columns button and deselect all of them leaving 0 active columns like on the video - Save button should be disabled. Otherwise it will lead to showing nothing at all which is not natural behaviour. Link to notebook: https://carbon-for-ibm-products.netlify.app/?path=/story/ibm-products-components-datagrid-columncustomization--column-customization-usage-story&globals=viewport:basic

video

Component(s) impacted

https://carbon-for-ibm-products.netlify.app/?path=/story/ibm-products-components-datagrid-columncustomization--column-customization-usage-story&globals=viewport:basic

Browser

Chrome, Safari

@carbon/ibm-products (previously @carbon/ibm-cloud-cognitive) version

2.45.0

Suggested Severity

None

Product/offering

IBM

CodeSandbox or Stackblitz example

https://carbon-for-ibm-products.netlify.app/?path=/story/ibm-products-components-datagrid-columncustomization--column-customization-usage-story&globals=viewport:basic

Steps to reproduce the issue (if applicable)

Customize Columns -> Deselect All -> Save

Release date (if applicable)

No response

Code of Conduct

szymonbrandys commented 2 months ago

It could be also a property that disallows saving configuration when all columns are unselected.

jakubkloc commented 1 month ago

Can you estimate when this issue will be resolved?

jakubkloc commented 1 month ago

its already implemented in 2.50.0 version?