carbon-design-system / ibm-products

A Carbon-powered React component library for IBM Products
https://ibm-products.carbondesignsystem.com
Apache License 2.0
92 stars 137 forks source link

[Feature Request]: Add custom svg slot on `FullPageError` for custom error pages #5975

Open stefan-cooper opened 2 weeks ago

stefan-cooper commented 2 weeks ago

The problem

I want to create a custom FullPageError for different error codes other than 404 and 403, and I want to use a different svg for each one.

The solution

Add a new optional custom slot/parameter for svgs that can be used when the kind is custom. If not provided, then it will use the existing behavior

Design link

No response

Links to other materials

No response

Owner/main maintainer(s)

.

Second/backup maintainer(s)

No response

Product/offering

IBM Event Endpoint Management

Business priority

None

Code of Conduct

kingtraceyj commented 2 days ago

@stefan-cooper do you mind sharing your imagery with us so we can understand a little more about the use case?

jeanservaas commented 2 days ago

@stefan-cooper just to clarify, we've chosed this suite of line-drawn monochromatic imagery specifically for these error states. This was discussed extensively in DSAG. If you want to contribute another illustration to this suite, that'd be awesome, and I'd take it up with Colleen Yates and the illustration guild. We'd like to avoid introducing other styles (full-color etc) in these scenarios for consistency.

If there's something you feel like we're not considering here, please come to office hours to discuss. Thanks so much!