carbon-design-system / ibm-products

A Carbon-powered React component library for IBM Products
https://ibm-products.carbondesignsystem.com
Apache License 2.0
92 stars 137 forks source link

[a11y]: Export Modal, Dialog heading is provided in h3 instead of h2 #6019

Closed devadula-nandan closed 6 days ago

devadula-nandan commented 1 week ago

Package

@carbon/ibm-products

Browser

Firefox

Operating System

Windows

Package version

v2.49.0-rc.0

React version

No response

Automated testing tool and ruleset

manual

Assistive technology

JAWS

Description

Reported by Raghu during screen reader testing.

Maintain hierarchical order for the Heading levels : Recommended to present the Modal Main heading in H2.

If page headings are not in the right sequence, screen reader users find it difficult to comprehend the hierarchical structure of the page content.

WCAG 2.1 Violation

1.3.1 Info & Relationships

Reproduction/example

https://ibm-products.carbondesignsystem.com/?path=/story/ibm-products-components-export-exportmodal--standard&globals=viewport:basic

Steps to reproduce

noticeable in storybook

Code of Conduct

anamikaanu96 commented 1 week ago

In export modal, we are using composed modal from carbon. This heading h3 is coming from there, I have raised the issue in carbon.

matthewgallo commented 6 days ago

Closing in favor of https://github.com/carbon-design-system/carbon/issues/17397