search

carbon-design-system / ibm-products

A Carbon-powered React component library for IBM Products
https://ibm-products.carbondesignsystem.com
Apache License 2.0
96 stars 137 forks source link

reconfigure eslint config for v9 #6187

Open davidmenendez opened 6 days ago

davidmenendez commented 6 days ago

our latest dev dependencies update updates eslint from v8 to v9, which is causing breaking changes

Image

elycheea commented 6 days ago

@davidmenendez Can you share some detailing on what’s involved in the upgrade from v8 to v9? Is it involved enough that it needs to be addressed separately from our dev dependencies?

davidmenendez commented 5 days ago

@elycheea yeah for sure.

i spent some time looking at this yesterday and i think we'll want to separate out the work because it seems to be a pretty big change. right now i'm not sure if eslint-config-carbon has been update to work with the v9. i'm also not sure if dependencies like eslint-plugin-jest have been updated and i think based on something i read somewhere while trying to fix this that typescript may not be supported yet.

out of curiosity i checked to see if carbon core is on v9 and they appear to be based on their current config but it also doesn't look like it's actually configured with anything. i was going to ask taylor about this haha.

so yeah i would say if we can cherry pick this update and separate it from our usual update cycle that we should because it appears to be a big change.