Open oliviaflory opened 1 week ago
Kenny's opinion is that tearsheet
should go into the Core library as variant of modal, rather than its own separate component. If you take out all the Product-specific pieces of Tearsheet, it's essentially a type of modal, with some style changes such as being pinned to the bottom and transitioning up from the bottom of the screen.
Tearsheet is too complex to move into core’s component library as-is. It should be simplified when brought to Core.
If the team sees internal components used in products library, then you should consider bringing to Core.
tearsheet
also bring in its stepping functionality to the Core library? Teams would likely have to add this themselves for Tearsheet. Element | Wide | Narrow |
---|---|---|
Header | – | – |
Label | ✅ | ✅ |
Title | ✅ | ✅ |
Description | ✅ | ✅ |
AI label | ✅ | ✅ |
Close | ✅ | ✅ |
Header actions | ✅ | 🚫 |
Tabs | ✅ | ✅ (We show this in docs, but not Storybook) |
Main structure | – | – |
Main area (scrollable) | ✅ | ✅ |
Footer actions / Navigation buttons | ✅ | ✅ (Recommend up to two buttons) |
Influencers | ✅ | 🚫 |
Stacking | ✅ | ✅ |
We advise not to use 2 influencers at the same time due to the lack of available screen space
appears in the docs.divider
styling is available in code for create flow
but not tearsheet
. We don’t mention this in our docs, but show it in the gifs.tearsheet
?Create flow
comes with a divider → are team’s using this?
CreateTearsheet
used to have a switch in the influencer to show all the steps at once. The divider would be used to separate out each step only when they were shown this way.
CreateTearsheet
, the buttons are out of their control. From a dev perspective, we should have the button footer as a slot which could have any button needed.
CreateTearsheet
.Tearsheet
does this a little better than CreateTearsheet
, with Tearsheet being closer what teams want. In that, the influencer has a prop that adopters can pass in what they want.CreateTearsheet
could be added to Tearsheet
.Tearsheet
?
Tearsheet
always has issues. I think it stems from the stacking functionality.
Tearsheet
, we need to clean up that code.Tearsheet
used frequently?
Tearsheet
that need refactoring/rethinking:
Component/Pattern | Repos | Metrics |
---|---|---|
Tearsheet | 1,570 | 552,556 |
CreateTearsheet | 1,871 | 10,609 |
CreateTearsheetStep | 1,871 | 27,394 |
To do: