Closed kristastarr closed 1 year ago
@elycheea @glapadre @tay1orjones Could one of y'all review this when you have time please? π
Name | Link |
---|---|
Latest commit | 55c30783b217680e0eb828539c077be547255f73 |
Latest deploy log | https://app.netlify.com/sites/carbon-icons-motion/deploys/6446ad5a57abec0008ab32a9 |
Deploy Preview | https://deploy-preview-232--carbon-icons-motion.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
@kristastarr Donβt forget to look into the package-lock!
@elycheea @tay1orjones I made the update to require one title
prop instead of two separate ones for needsTitle
and customTitle
. Updated propTypes as well. Now there is a default title (the icon's name) if not otherwise specified.
I don't think this is the most eloquent solution but it's working. Is it okay with y'all if I go ahead and merge it, and can improve on it later?
@elycheea @tay1orjones I made the update to use one title
prop instead of two separate ones for needsTitle
and customTitle
. Updated propTypes as well. Now there is a default title (the icon's name) if not otherwise specified.
I don't think this is the most eloquent solution but it's working. Is it okay with y'all if I go ahead and merge it, and can improve on it later?
Updates to the
Idea
icon which were prioritized because they are being used in production right now and the removal of the svg<title>
is necessary... these changes will be applied to additional icons in the futureIdeaMotion
component to reduce amount of codeneedsTitle
needsTitle
isfalse
, or if a prop is not provided (because the developer plans to provide naming for icon via other means) then there will be no<title>
element in the svgneedsTitle
istrue
, a custom title can be specified using the optionalcustomTitle
prop. IfneedsTitle
is set totrue
and nocustomTitle
prop is provided, the default title will be the icon's name as indicated in CarbonfillColor
fillColor
prop, that will be the color of the icon. If none is provided, it will be G100 (#161616
)#