search

carbon-design-system / icons-motion

A library of animated Carbon icons
Apache License 2.0
17 stars 10 forks source link

Update to React 17 #265

Closed kristastarr closed 1 year ago

kristastarr commented 1 year ago
netlify[bot] commented 1 year ago

Deploy Preview for carbon-icons-motion ready!

Name Link
Latest commit 67e720622e56436588302c9cac77029d57b76479
Latest deploy log https://app.netlify.com/sites/carbon-icons-motion/deploys/64e6955d708e8800075242fc
Deploy Preview https://deploy-preview-265--carbon-icons-motion.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kristastarr commented 1 year ago

@SimonFinney I published a new package update including @glapadre's new icons for Cygnus, but was unable to test in a fresh create react app, since it required React 18, and the icon package is still using 16. This dependabot PR https://github.com/carbon-design-system/icons-motion/pull/236 tried to update to React 18, but there were merge conflicts in the package-lock.json so I attempted to do it manually. I actually updated to React 17 instead since I was worried it would cause issues with Cygnus, since y'all are using 17... would it?

@alisonjoseph @tay1orjones Should I further update to React 18, to be consistent with Carbon?

tay1orjones commented 1 year ago

Hey! React 18 support would be ideal but understand if it's too much to contain for you right now. The big blocker for us was we had our whole test suite using enzyme which isn't compatible with v18. We had to refactor the entire thing to use @testing-library/react which took quite a while. From a quick glance it looks like you might not need to do much, it would primarily consist of updating to the new createRoot API in your example(s).