carbon-design-system / icons-motion

A library of animated Carbon icons
Apache License 2.0
17 stars 10 forks source link

chore: onboard @carbon/icons-motion to IBM Telemetry 🚀 #274

Closed mattrosno closed 5 months ago

mattrosno commented 5 months ago

Related Ticket(s)

N/A

Description

Adds the config file and dependency necessary to start tracking telemetry data via IBM Telemetry for the packages:

The YML config file was generated with:

npx -y @ibm/telemetry-js-config-generator --id 33e86bff-4d6c-4de0-8b74-6c4f5fc981ef --endpoint https://collector-prod.1am6wm210aow.us-south.codeengine.appdomain.cloud/v1/metrics --files ./src/components/**/*.(tsx|js|jsx)

Changelog

New

Changed

Removed

Testing

Please look through package.json config files and ensure all necessary modifications have been made so that the "telemetry.yml" config file is included in the release version of each package.

PLEASE NOTE: In order for IBM Telemetry to start collecting data for this project, a new build must be published including these changes.

netlify[bot] commented 5 months ago

Deploy Preview for carbon-icons-motion ready!

Name Link
Latest commit 21eb6a919048672254f9d1d3478404916f6d92eb
Latest deploy log https://app.netlify.com/sites/carbon-icons-motion/deploys/6604371295338600085ed40f
Deploy Preview https://deploy-preview-274--carbon-icons-motion.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mattrosno commented 5 months ago

@kristastarr - hi! Let me know if you have any questions about this PR. What version of node are you using? I see the package.json only specifies >= node 10. I see me installing @ibm/telemetry-js made more changes to the package-lock.json file than I anticipated. Is this okay? @jdharvey-ibm @francinelucca

kristastarr commented 5 months ago

@mattrosno Yes changes to the package-lock.json are fine! It's well overdue for me to update the node version