search

carbon-io / carbond

MIT License
2 stars 5 forks source link

Collection doesn't honor parameters in findObjectConfig #207

Closed rmiyashiro closed 7 years ago

rmiyashiro commented 7 years ago

I have a Collection and I want to support some query parameters to the findObject method (e.g. /things/:id?awesome=true), but it seems that the parameters config is ignored in findObjectConfig. You can still access the query raw via ctx.req.query but it would be nice if it worked consistently with the other methods, plus it's more convenient to be able to define a schema for the parameter.

Also, though I have not confirmed, I suspect this is an issue with the other *Object sub endpoints as well.

willshulman commented 7 years ago

Looks like same as: https://github.com/carbon-io/carbond/issues/136

willshulman commented 7 years ago

Robert you want to take a stab at this one? Might be fastest way -- see linked ticket I think it is a simple fix.

rmiyashiro commented 7 years ago

Fixed in #136