search

carbon-io / carbond

MIT License
2 stars 5 forks source link

[v0.7] gen-static-docs doesn't generate docs for insertObject #237

Closed tfogo closed 7 years ago

tfogo commented 7 years ago

When generating docs for examples using the new collections I found that POSTs are missing from the documentation. I presume this has something to do with insertObject being a new method.

To replicate, checkout the collection-overhaul2 branch of the Contacts Service: https://github.com/carbon-io-guides/example__contact-service

That branch has the old docs in the docs folder. Regenerate the docs and the new docs will be missing the POSTs.

willshulman commented 7 years ago

The docgen is based on seeing the Service as a tree of Endpoints (i.e. the docgen code does not know about Collections). So insertObject being new should not matter. Greg might have a better idea.

gregbanks commented 7 years ago

hmm... not able to reproduce this with the latest version of carbond#collection-overhaul. can you pull and try to reproduce?

tfogo commented 7 years ago

@gregbanks I pulled and I was still able to reproduce it. When you have time do you want to look at it together?

tfogo commented 7 years ago

Yeah it's working now.