Do we need Authenticator.isRootUser and Authenticator.getAuthenticationHeaders?

carbon-io / carbond

MIT License

2 stars 5 forks source link

Do we need Authenticator.isRootUser and Authenticator.getAuthenticationHeaders? #256

Closed tfogo closed 6 years ago

tfogo commented 6 years ago

These are abstract methods. Neither of them are implemented in Authenticator's subclasses. (actually getAuthenticationHeaders is implemented in ApiKeyAuthenticator but is unused.)

Do we need them?

tfogo commented 6 years ago

getAuthenticationHeaders is used - see #319

willshulman commented 6 years ago

Thx. Sorry that I missed the question originally on Oct 19th.