Closed tfogo closed 6 years ago
@gregbanks when you get a chance, would you mind looking at this to make sure it's good?
My commit history is a bit messy, so if we're going to merge this PR, let's squash and merge.
looks good (see comments) after a quick pass
Cool, will make those changes
@gregbanks Made those changes, also fixed a mistake in the HttpBasicAuthenticator documentation.
🍥
@gregbanks when you get a chance, would you mind looking at this to make sure it's good?
My commit history is a bit messy, so if we're going to merge this PR, let's squash and merge.