search

carbon-io / carbond

MIT License
2 stars 5 forks source link

SaveObjectConfig.supportsUpdate #280

Open willshulman opened 7 years ago

willshulman commented 7 years ago

I want to revisit whether SaveObjectConfig should support the idea of disabling updates (i.e. just supporting inserts). I believe we already have a flag to control whether upsert is supported.

The use-case is particular interesting for MongoDBCollection. In a case where the client would like to supply _id values on insert Collections dictate that one should use PUT to the object sub-endpoint. However, if we don't support disabling updates then there is not way to support inserts but not updates, which feels like a gap.

Thoughts? We can also discuss live.

gregbanks commented 6 years ago

i think this should be closed, but downgrading after in person discussion for now.