search

carbon-io / carbond

MIT License
2 stars 5 forks source link

noDocument on insert and insertObject. #301

Closed tfogo closed 6 years ago

tfogo commented 6 years ago

I would expect this to be && not ||: https://github.com/carbon-io/carbond/blob/master/lib/collections/Collection.js#L1119

My thinking is noDocument should be true on both insert and insertObject for POST not to be documented. Thoughts?

gregbanks commented 6 years ago

i would err on the side of safety here, hence the ||. in other words, if the programmer explicitly sets noDocument to true for insert, their expectation is for that operation not to be included in the documentation, which should be honored.