Should pre and post<OperationName>Operation be _post<OperationName>Operation?

carbon-io / carbond

MIT License

2 stars 5 forks source link

Should pre and post<OperationName>Operation be _post<OperationName>Operation? #306

Open tfogo opened 6 years ago

tfogo commented 6 years ago

Adding _ would emphasize that in general it shouldn't be overridden unless you know what you're doing.

chrisckchang commented 6 years ago

just a reminder: relevant doc section that would need changing https://docs.carbon.io/en/master/packages/carbond/docs/guide/collections/collection-operation-hooks.html

gregbanks commented 6 years ago

adding a leading underscore would also have the side effect of filtering it from class refs. i wish there was a better distinction between protected/private members...