search

carbon-language / carbon-lang

Carbon Language's main repository: documents, design, implementation, and related tools. (NOTE: Carbon Language is experimental; see README)
https://github.com/carbon-language/carbon-lang/blob/trunk/README.md
Other
32.31k stars 1.48k forks source link

Disable autoupdate in explorer tests. #4023

Closed jonmeow closed 4 weeks ago

jonmeow commented 4 weeks ago

Just replacing AUTOUPDATE with NOAUTOUPDATE, and removing the autoupdate script. Tests will still run, but autoupdate may need to be fixed if significant changes are made.

I noticed this while trying to autoupdate for #4007 (because we verify that tests have been autoupdated). Autoupdate was likely broken by #3449.

Trying to run with no changes gives:

CHECK failure at testing/file_test/file_test_base.cpp:801: !absl::GetFlag(FLAGS_test_targets_file).empty(): Missing --test_targets_file.

This is because the file_test rule creates a file with test inputs that it runs with, which the prebuilt binary doesn't provide.

A local kludge to create a file_test target not using prebuilt_binary showed another error:

: CommandLine Error: Option ': CommandLine Error: Option 'parser_debug' registered more than once!
LLVM ERROR: inconsistency in registered CommandLine options
trace_phase' registered more than once!
LLVM ERROR: inconsistency in registered CommandLine options

I'm thinking here that the explorer code hasn't been in enough use, and we're seeing some rot as a consequence. Rather than trying to maintain it, I'm suggesting to go with NOAUTOUPDATE.

jonmeow commented 4 weeks ago

Yeah, one big search-and-replace. And then fixing where I accidentally did NOAUTOUPDATE -> NONOAUTOUPDATE